[PATCH] D86218: Teach the swift calling convention about _Atomic types

2020-08-31 Thread Arnold Schwaighofer via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG41634497d4fd: Teach the swift calling convention about _Atomic types (authored by aschwaighofer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86218/new/ h

[PATCH] D86218: Teach the swift calling convention about _Atomic types

2020-08-21 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86218/new/ https://reviews.llvm.org/D86218

[PATCH] D86218: Teach the swift calling convention about _Atomic types

2020-08-21 Thread Arnold Schwaighofer via Phabricator via cfe-commits
aschwaighofer updated this revision to Diff 287055. aschwaighofer added a comment. Respect atomic padding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86218/new/ https://reviews.llvm.org/D86218 Files: clang/lib/CodeGen/SwiftCallingConv.cpp c

[PATCH] D86218: Teach the swift calling convention about _Atomic types

2020-08-20 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Please do this as a very late check rather than the first check. You need to check for extra atomic padding. If there's any difference between the sizes of the atomic type and its element, just add it as opaque data. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D86218: Teach the swift calling convention about _Atomic types

2020-08-19 Thread Arnold Schwaighofer via Phabricator via cfe-commits
aschwaighofer updated this revision to Diff 286575. aschwaighofer added a comment. Try to sooth clang-tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86218/new/ https://reviews.llvm.org/D86218 Files: clang/lib/CodeGen/SwiftCallingConv.cpp c

[PATCH] D86218: Teach the swift calling convention about _Atomic types

2020-08-19 Thread Arnold Schwaighofer via Phabricator via cfe-commits
aschwaighofer created this revision. aschwaighofer added a reviewer: rjmccall. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. aschwaighofer requested review of this revision. rdar://67351073 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D86218 Files