[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

tambre updated this revision to Diff 286957. tambre added a comment. Herald added a project: libunwind. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libunwind. Add workaround for Apple, and for MinGW prior to CMake 3.17. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

mstorsjo added a comment. Just FWIW, a similar change was made in libunwind earlier (c48974ffd7d1676f79d39d3b1e70f07d3a5e2e44 ), which then required workarounds for cmake issues on both mingw and macos (see

[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

phosek added a comment. In D86308#2228917 , @tambre wrote: > I'm pretty sure `add_asm_sources()` has nothing to do. The ASM language is > enabled by compiler-rt anyway and CMake can recognize the files as assembly > anyway. Can we remove that function

[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

tambre added a comment. I'm pretty sure `add_asm_sources()` has nothing to do. The ASM language is enabled by compiler-rt anyway and CMake can recognize the files as assembly anyway. @teemperor Could you give this a try? If this doesn't work, could you upload the Ninja file for me to

[PATCH] D86308: Reland [compiler-rt] Compile assembly files as ASM not C

tambre created this revision. tambre added reviewers: phosek, teemperor. Herald added subscribers: Sanitizers, cfe-commits, dexonsmith, kristof.beyls, mgorny, dberris. Herald added projects: clang, Sanitizers. tambre requested review of this revision. It isn't very wise to pass an assembly file