[PATCH] D86376: [HIP] Emit kernel symbol

This revision was automatically updated to reflect the committed changes. Closed by commit rG5cf2a37f1255: [HIP] Emit kernel symbol (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D86376?vs=322894=327268#toc Repository: rG LLVM Github

[PATCH] D86376: [HIP] Emit kernel symbol

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. So, to summarize how the patch changes the under-the-hood kernel launch machinery: - device-side is unchanged. Kernel function is generated with the real kernel name - host-side stub is still

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86376/new/ https://reviews.llvm.org/D86376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl updated this revision to Diff 322894. yaxunl added a comment. handle launch kernel by API and launch kernel in function pointer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86376/new/ https://reviews.llvm.org/D86376 Files: clang/lib/CodeGen/CGCUDANV.cpp

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl added a comment. In D86376#2552524 , @tra wrote: > In D86376#2552419 , @yaxunl wrote: > >> For triple chevron with kernel name, it is not needed. We only need >> indirection for a triple chevron with a

[PATCH] D86376: [HIP] Emit kernel symbol

tra added a comment. In D86376#2552419 , @yaxunl wrote: > For triple chevron with kernel name, it is not needed. We only need > indirection for a triple chevron with a function pointer, in which case we do > not know its stub function at compile time.

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl added a comment. In D86376#2552066 , @tra wrote: > In D86376#2551298 , @yaxunl wrote: > >> Actually there is one issue with this approach. >> >> HIP have API's to launch kernels, which accept kernel as

[PATCH] D86376: [HIP] Emit kernel symbol

tra added a comment. In D86376#2551298 , @yaxunl wrote: > Actually there is one issue with this approach. > > HIP have API's to launch kernels, which accept kernel as function pointer > argument. Currently when taking address of kernel, we get the stub

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl added a comment. Actually there is one issue with this approach. HIP have API's to launch kernels, which accept kernel as function pointer argument. Currently when taking address of kernel, we get the stub function. These kernel launching API's will not work if we use kernel symbol to

[PATCH] D86376: [HIP] Emit kernel symbol

yaxunl updated this revision to Diff 322213. yaxunl retitled this revision from "[HIP] Simplify kernel launching" to "[HIP] Emit kernel symbol". yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Artem's comments. CHANGES SINCE LAST ACTION