This revision was automatically updated to reflect the committed changes.
Closed by commit rG2b37174b9a5d: [clang][Driver] Implement
AddClangSystemIncludeArgs and HasNativeLLVMSupport… (authored by brad).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
3405691582 added a comment.
Thanks! please commit on my be half as appropriate.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86412/new/
https://reviews.llvm.org/D86412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
brad accepted this revision.
brad added a comment.
This revision is now accepted and ready to land.
I was wondering why we had not seen any issues like this but your followup post
clarified the situation.
Thank you.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86412/new/
https
3405691582 updated this revision to Diff 287263.
3405691582 edited the summary of this revision.
3405691582 added a comment.
Those platforms still use the legacy mechanism in `InitHeaderSearch.cpp`. For
platforms which have moved include handling to the driver, the mechanism in
`InitHeaderSearch
brad added a comment.
Looks reasonable. I'm a little surprised I don't see this in the FreeBSD
driver. What about FreeBSD, NetBSD and DragonFly?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86412/new/
https://reviews.llvm.org/D86412
___
cfe
3405691582 updated this revision to Diff 287238.
3405691582 added a comment.
Finally got the formatting fixed properly.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86412/new/
https://reviews.llvm.org/D86412
Files:
clang/lib/Driver/ToolChains/OpenBSD.cpp
clang/lib/Driver/ToolChain
3405691582 updated this revision to Diff 287237.
Herald added a subscriber: fedor.sergeev.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86412/new/
https://reviews.llvm.org/D86412
Files:
clang/lib/Driver/ToolChains/OpenBSD.cpp
clang/lib/Driver/ToolChains/OpenBSD.h
Index: clang/lib/D
3405691582 created this revision.
3405691582 added a reviewer: brad.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
3405691582 requested review of this revision.
If not overridden, `AddClangSystemIncludeArgs`'s implementation is empty, so by
default, no system include args