[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

2020-09-01 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2114f71aaa8d: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl() (authored by nullptr.cpp, committed by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

2020-08-31 Thread Yang Fan via Phabricator via cfe-commits
nullptr.cpp added a comment. @jdoerfert @ABataev I don't have commit access, can you help commit this? Yang Fan Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

2020-08-31 Thread Yang Fan via Phabricator via cfe-commits
nullptr.cpp updated this revision to Diff 289069. nullptr.cpp added a comment. trigger rebuild Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858 Files: clang/lib/Sema/SemaOpenMP.cpp Index:

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

2020-08-31 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858 ___

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

2020-08-31 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. LG, @ABataev ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

2020-08-31 Thread Yang Fan via Phabricator via cfe-commits
nullptr.cpp added a comment. In D86858#2246925 , @jdoerfert wrote: > Can you add the test that exposed this? Sorry, this was discovered by a static analyzer checker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

2020-08-31 Thread Yang Fan via Phabricator via cfe-commits
nullptr.cpp updated this revision to Diff 288894. nullptr.cpp added a comment. Fix by changing the loop condition to `Level > 0`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858 Files:

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

2020-08-30 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Can you add the test that exposed this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86858/new/ https://reviews.llvm.org/D86858 ___ cfe-commits mailing list

[PATCH] D86858: [OpenMP] Fix infinite loop in Sema::isOpenMPGlobalCapturedDecl()

2020-08-30 Thread Yang Fan via Phabricator via cfe-commits
nullptr.cpp created this revision. nullptr.cpp added a reviewer: ABataev. Herald added subscribers: cfe-commits, danielkiss, guansong, yaxunl. Herald added a project: clang. nullptr.cpp requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1.