[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaronpuchert planned changes to this revision. aaronpuchert added a comment. That's a good point, while `mu_` is public, `params` is a local variable. I need to take into account the left-hand side of a `til::Project`, which we're currently ignoring. Repository: rG LLVM Github Monorepo

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

rupprecht added a comment. In D87194#2369485 , @aaronpuchert wrote: > @rupprecht, maybe you can try it again? Some more interesting errors this time :) The ones I originally saw look correct now (i.e. it's flagging the things that are valid, but not

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaronpuchert added a subscriber: rupprecht. aaronpuchert added a comment. @rupprecht, maybe you can try it again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87194/new/ https://reviews.llvm.org/D87194

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaronpuchert updated this revision to Diff 302388. aaronpuchert marked 2 inline comments as done. aaronpuchert added a comment. Rebased on D84604 , included static members, and addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaronpuchert added inline comments. Comment at: clang/test/SemaCXX/warn-thread-safety-negative.cpp:158 +} + } // end namespace ScopeTest aaron.ballman wrote: > Given that this is touching on declaration contexts, it would also be good to > have some tests

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaron.ballman added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1283 + return true; +// We are ignoring friends here. if (!CurrentMethod) This should probably have a FIXME? Comment at:

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaronpuchert planned changes to this revision. aaronpuchert added a comment. Need to rebase this on top of D84604 plus a subsequent fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87194/new/

[PATCH] D87194: Thread safety analysis: Use access specifiers to decide about scope

aaronpuchert created this revision. aaronpuchert added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. aaronpuchert requested review of this revision. Public members are always in scope, protected members in derived classes with sufficient access.