[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mati865 added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87539/new/ https://reviews.llvm.org/D87539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

This revision was automatically updated to reflect the committed changes. Closed by commit rG7da941939902: [MinGW][libclang] Allow simultaneous shared and static lib (authored by mati865, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM then! Can apply it a bit later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87539/new/ https://reviews.llvm.org/D87539

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mati865 added a comment. Sorry, pasted wrong command. I was curious if import library has it (since static one did not) but in the end neither import nor static library shows any `export`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87539/new/

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mstorsjo added a comment. In D87539#2269442 , @mati865 wrote: > `bin/llvm-readobj --coff-directives lib/liblibclang.dll.a | grep -i export` > shows nothing. That's the import library, not the static library. Repository: rG LLVM Github Monorepo

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mati865 added a comment. `bin/llvm-readobj --coff-directives lib/liblibclang.dll.a | grep -i export` shows nothing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87539/new/ https://reviews.llvm.org/D87539

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mstorsjo added a comment. In D87539#2269385 , @mati865 wrote: > We had this patch at MSYS2 for years and I'm not aware of any issues with the > static library. > I think the library looks fine: > > $ nm lib/liblibclang.a | grep __imp_ >

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mati865 added a comment. We had this patch at MSYS2 for years and I'm not aware of any issues with the static library. I think the library looks fine: $ nm lib/liblibclang.a | grep __imp_ U __imp___acrt_iob_func U __imp___acrt_iob_func

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mstorsjo added a comment. Does the static lib built in this case include any dllexport attributes (that can cause issues if linking it statically into another DLL)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87539/new/

[PATCH] D87539: [MinGW][libclang] Allow simultaneous shared and static lib

mati865 created this revision. mati865 added a reviewer: clang. mati865 added a project: clang. Herald added subscribers: cfe-commits, mgorny. mati865 requested review of this revision. It builds fine for MinGW on Windows. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87539