This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Conanap marked an inline comment as done.
Closed by commit rG88cdbeab417c: [PowerPC] Implement Vector signed/unsigned
__int128 overloads for the… (authored by Conanap).
amyk accepted this revision.
amyk added a comment.
This revision is now accepted and ready to land.
Forgot to approve this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87804/new/
https://reviews.llvm.org/D87804
amyk added a comment.
Please address clang-format issues and Lei's comments. Other than that, I think
the patch LGTM.
Comment at: llvm/test/CodeGen/PowerPC/vec_cmpq.ll:14
+; CHECK-LABEL: v1si128_cmp:
+; CHECK: vcmpequq 2, 2, 3
+}
lei wrote:
> please add the ch
lei added a comment.
please fix the clang format issues.
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:365
+ def int_ppc_altivec_vcmpequq : GCCBuiltin<"__builtin_altivec_vcmpequq">,
+ Intrinsic<[llvm_v1i128_ty], [llvm_v1i128_ty, llvm_v1i128_ty],
+
Conanap created this revision.
Conanap added reviewers: PowerPC, saghir, nemanjai, hfinkel.
Conanap added projects: LLVM, PowerPC, clang.
Herald added a subscriber: kbarton.
Conanap requested review of this revision.
This patch implements Vector signed/unsigned __int128 overloads for the
comparis
