[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

2020-10-19 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added a comment. In D87830#2336572 , @njames93 wrote: > Probably not quite as verbose but should do the job > > // RUN: clang-tidy %s --checks=-*,my-check-to-test --warnings-as-errors=* > -- -std=c++11 Thanks 👍 ! I can live with this solution

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

2020-10-16 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Probably not quite as verbose but should do the job // RUN: clang-tidy %s --checks=-*,my-check-to-test --warnings-as-errors=* -- -std=c++11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87830/new/ https://reviews.llvm.

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

2020-10-16 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added a comment. In D87830#2298198 , @aaron.ballman wrote: > > know of any tests that are impacted by this? I haven't found any tidy-tests that were negative-tests (ie.: tests that assert that there are no diagnostics). > ... if I underst

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

2020-09-28 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thank you for the changes, but do you know of any tests that are impacted by this? I'm not opposed to the proposed changes, but I am wondering -- the current behavior is that an empty output file (which can happen with especially egregious bugs) is always an error

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

2020-09-28 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 added a comment. Do you have some thoughts about this, should this be pursued, or do you think the use-case is not relevant? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87830/new/ https://reviews.llvm.org/D87830 __

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

2020-09-17 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 292487. gamesh411 added a comment. Tidy up commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87830/new/ https://reviews.llvm.org/D87830 Files: clang-tools-extra/test/clang-tidy/check_clang_tidy.

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

2020-09-17 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 updated this revision to Diff 292485. gamesh411 added a comment. Update commit msg with example Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87830/new/ https://reviews.llvm.org/D87830 Files: clang-tools-extra/test/clang-tidy/check_cla

[PATCH] D87830: [clang-tidy][test] Allow empty checks in check_clang_tidy.py

2020-09-17 Thread Endre Fülöp via Phabricator via cfe-commits
gamesh411 created this revision. Herald added subscribers: cfe-commits, martong, steakhal, Szelethus, dkrupp, xazax.hun, whisperity. Herald added a project: clang. gamesh411 requested review of this revision. Currently there is no way to assert that a check does not produce warnings for a specif