[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

nemanjai added a comment. It turns out that the culprit for the PPC bot failures is actually https://reviews.llvm.org/rG144e57fc9535 But this just took a while to manifest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87921/new/

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

MaskRay added a comment. When you recommit, consider adding the header to the description. The original message started with "The wrong placement of add pass with optimizations led to -funique-internal-linkage-names being disabled." The header was missing. Repository: rG LLVM Github

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

nemanjai added a comment. In D87921#2288686 , @morehouse wrote: > The revert did not fix the PPC bots. I suspect there is some kind of > resource issue from the logs: > > msgget:: No space left on device > sysmsg.c.tmp: >

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

morehouse added a comment. The revert did not fix the PPC bots. I suspect there is some kind of resource issue from the logs: msgget:: No space left on device sysmsg.c.tmp:

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

MaskRay added a comment. In D87921#2288395 , @Conanap wrote: > It looks like this commit is causing a few failures on nearly all PPC bots > and a sanitizer bot; would it be possible to revert this commit for now until > the issue is resolved? It would

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

On Tue, Sep 22, 2020 at 11:28 AM Albion Fung via Phabricator wrote: > > Conanap added a comment. > > It looks like this commit is causing a few failures on nearly all PPC bots > and a sanitizer bot; would it be possible to revert this commit for now until > the issue is resolved? Ya sure, I

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

Conanap added a comment. It looks like this commit is causing a few failures on nearly all PPC bots and a sanitizer bot; would it be possible to revert this commit for now until the issue is resolved? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

saghir added a comment. In D87921#2288096 , @morehouse wrote: > Thanks for looking. Indeed, it looks like an issue with the disk being full > on the bot. Hi, I checked the disk is not full on the bot. I am not sure what is going on here but its

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

morehouse added a comment. Thanks for looking. Indeed, it looks like an issue with the disk being full on the bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87921/new/ https://reviews.llvm.org/D87921

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

On Tue, Sep 22, 2020 at 8:34 AM Fāng-ruì Sòng wrote: > > FWIW I tested check-msan in a -DCMAKE_BUILD_TYPE=Release build on a > powerpc64le machine. All tests passed. I cannot connect the failure to > the clang patch. Thanks for doing this! Much appreciated! > > On Mon, Sep 21, 2020 at 10:02 PM

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

FWIW I tested check-msan in a -DCMAKE_BUILD_TYPE=Release build on a powerpc64le machine. All tests passed. I cannot connect the failure to the clang patch. On Mon, Sep 21, 2020 at 10:02 PM Sriraman Tallam wrote: > > On Mon, Sep 21, 2020 at 5:58 PM Matt Morehouse via Phabricator > wrote: > > > >

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

On Mon, Sep 21, 2020 at 5:58 PM Matt Morehouse via Phabricator wrote: > > morehouse added a comment. > > This change appears to trigger an assertion failure in sysmsg.c on the PPC > bot: > http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/26845/steps/ninja%20check% > >

Re: [PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

On Mon, Sep 21, 2020 at 5:58 PM Matt Morehouse via Phabricator wrote: > > morehouse added a comment. > > This change appears to trigger an assertion failure in sysmsg.c on the PPC > bot: > http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/26845/steps/ninja%20check% > >

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

morehouse added a comment. This change appears to trigger an assertion failure in sysmsg.c on the PPC bot: http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/26845/steps/ninja%20check% TEST 'SanitizerCommon-msan-powerpc64le-Linux :: Linux/sysmsg.c' FAILED

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

This revision was automatically updated to reflect the committed changes. Closed by commit rG6950db36d33d: The wrong placement of add pass with optimizations led to -funique-internal… (authored by tmsriram). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to