[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

2020-11-17 Thread Ankit via Phabricator via cfe-commits
quic_aankit added a comment. In D88138#2397785 , @vtjnash wrote: > I think this, and similar recent commits, are causing the shared library > builds to fail some tests if this code gets linked into libLLVM.so: >

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

2020-11-16 Thread Jameson Nash via Phabricator via cfe-commits
vtjnash added a comment. I think this, and similar recent commits, are causing the shared library builds to fail some tests if this code gets linked into libLLVM.so: https://bugs.llvm.org/show_bug.cgi?id=48181. I assume it might actually a bug in ld (GNU Binutils for Ubuntu 2.34), as I don't

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

2020-10-05 Thread Alina Sbirlea via Phabricator via cfe-commits
asbirlea added a comment. Thank you, Ankit! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88138/new/ https://reviews.llvm.org/D88138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

2020-09-30 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D88138#2304243 , @quic_aankit wrote: > @aeubanks Thanks for the review. Can you also commit the patch on my behalf? Committed in ce5379f0f0675592fd10a522009fd5b1561ca72b

[PATCH] D88138: [NPM] Add target specific hook to add passes for New Pass Manager

2020-09-30 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGce5379f0f067: [NPM] Add target specific hook to add passes for New Pass Manager (authored by aeubanks). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github