[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson updated this revision to Diff 296689. arichardson added a comment. Use an enum config option instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88227/new/ https://reviews.llvm.org/D88227 Files:

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

mzeren-vmw added a comment. Perhaps PointerAlignment should be an enum of Left, Middle, Right? We maintain an internal patch that adds "ReferenceAlignment" as separate from PointerAlignment. So one could have: PointerAlignment: Middle ReferenceAlignment: Left Repository: rG LLVM Github

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson added inline comments. Comment at: clang/include/clang/Format/Format.h:2181 + /// \endcode + bool SpaceBeforePointerQualifiers; + MyDeveloperDay wrote: > I wonder if a request would ever say they wanted this Space before to be > Left/Middle/Right?

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:2181 + /// \endcode + bool SpaceBeforePointerQualifiers; + I wonder if a request would ever say they wanted this Space before to be Left/Middle/Right? perhaps this should

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson updated this revision to Diff 294090. arichardson added a comment. - Add a multi-variable-decl test (depends on D88239 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88227/new/

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson updated this revision to Diff 294049. arichardson marked 3 inline comments as done. arichardson added a comment. merge if with existing condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88227/new/ https://reviews.llvm.org/D88227

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

jrtc27 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2874-2889 + if (Left.is(TT_PointerOrReference)) { +if (Style.SpaceBeforePointerQualifiers && +Right.canBePointerOrReferenceQualifier()) + return true; return

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2874-2889 + if (Left.is(TT_PointerOrReference)) { +if (Style.SpaceBeforePointerQualifiers && +Right.canBePointerOrReferenceQualifier()) + return true; return

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

jrtc27 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2874-2889 + if (Left.is(TT_PointerOrReference)) { +if (Style.SpaceBeforePointerQualifiers && +Right.canBePointerOrReferenceQualifier()) + return true; return

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2874-2889 + if (Left.is(TT_PointerOrReference)) { +if (Style.SpaceBeforePointerQualifiers && +Right.canBePointerOrReferenceQualifier()) + return true; return

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

jrtc27 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2874-2889 + if (Left.is(TT_PointerOrReference)) { +if (Style.SpaceBeforePointerQualifiers && +Right.canBePointerOrReferenceQualifier()) + return true; return

[PATCH] D88227: [clang-format] Add a SpaceBeforePointerQualifiers style option

arichardson created this revision. arichardson added reviewers: JakeMerdichAMD, MyDeveloperDay, jrtc27. Herald added subscribers: cfe-commits, krytarowski, emaste. Herald added a project: clang. arichardson requested review of this revision. Some projects (e.g. FreeBSD) align pointers to the