[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

djasper added a comment. Sorry for being a bit late here and thanks @klimek for bringing this to my attention. This has been years ago, but if I reconstruct my thinking (and look at the test cases), then I'd say that "left" alignment should not be applied to multi-variable decl statements

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

MyDeveloperDay added a comment. I think this patch needs rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88239/new/ https://reviews.llvm.org/D88239 ___ cfe-commits mailing list

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

MyDeveloperDay added subscribers: sammccall, djasper, klimek. MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6636 - verifyFormat("a *a = aaa, *b = bbb,\n" - " *b =

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

arichardson added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88239/new/ https://reviews.llvm.org/D88239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

arichardson added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6636 + verifyFormat("a* a = aaa, * b = bb,\n" + " * b = bbb, * d = ;", Style);

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2889 + return true; +return Style.PointerAlignment != FormatStyle::PAS_Left; } I wish more of these horrendous expressions all over the code were written like

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

arichardson created this revision. arichardson added reviewers: JakeMerdichAMD, MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. arichardson requested review of this revision. While writing tests for D88227 , I noticed that