adamcz added a comment.
Just noticed: typo in commit description - compeltions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88281/new/
https://reviews.llvm.org/D88281
___
cfe-commits mailing list
usaxena95 updated this revision to Diff 294711.
usaxena95 marked an inline comment as done.
usaxena95 added a comment.
Added fixme for renaming evaluate() and fixed typo.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88281/new/
adamcz accepted this revision.
adamcz added inline comments.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1635
+case RM::Heuristics:
+ Scores.Quality = Quality.evaluate();
+ Scores.Relevance = Relevance.evaluate();
usaxena95 wrote:
>
usaxena95 added a comment.
If we just consider ranking, there are not many code paths. Most of the code
paths are for gathering and creating code completion items.
In the end all the code paths end up in the `addCandidate` method to get
`scored` either by heuristics or by decision forest.
So I
usaxena95 updated this revision to Diff 294684.
usaxena95 marked 2 inline comments as done.
usaxena95 added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88281/new/
https://reviews.llvm.org/D88281
Files:
adamcz accepted this revision.
adamcz added a comment.
This revision is now accepted and ready to land.
Could you add a test that sets this flag? Perhaps we can run
CodeCompletionTests.cpp twice, once with this flag, once without? Just to
exercise these code paths, I think most expectations
usaxena95 updated this revision to Diff 294281.
usaxena95 added a comment.
Moved DF evaluation to Quality.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88281/new/
https://reviews.llvm.org/D88281
Files:
usaxena95 created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang.
Herald added a project: clang.
usaxena95 requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
By default clangd scores a code completion item using heuristic model.
