This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG01a30fa6787d: [clangd] Trivial setter support when moving
items to fields (authored by njames93).
Repository:
rG LLVM Github Monorepo
CHANGES
kadircet accepted this revision.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/Hover.cpp:466
+auto *ND = llvm::dyn_cast(CE->getCalleeDecl());
+if (!ND)
+ return llvm::None;
njames93 wrote:
> kadircet wrote:
> > nit: combine
njames93 added inline comments.
Comment at: clang-tools-extra/clangd/Hover.cpp:461
+ if (auto *CE = llvm::dyn_cast(RHS->IgnoreCasts())) {
+// Make sure we get the version of move with 1 arg, the other is for moving
+// ranges.
sammccall wrote:
> nit:
njames93 updated this revision to Diff 294357.
njames93 marked 2 inline comments as done.
njames93 added a comment.
Updated function doc
Fix potential assertion
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88297/new/
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/Hover.cpp:414
// If CMD is one of the forms:
// void foo(T arg) { FieldName = arg; }
// R foo(T arg) { FieldName = arg; return *this; }
can you also update the docs?
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice, thanks!
Comment at: clang-tools-extra/clangd/Hover.cpp:461
+ if (auto *CE = llvm::dyn_cast(RHS->IgnoreCasts())) {
+// Make sure we get the version of move
njames93 created this revision.
njames93 added reviewers: sammccall, kadircet, hokein.
Herald added subscribers: cfe-commits, usaxena95, arphaman.
Herald added a project: clang.
njames93 requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Extend the Trivial setter
