[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

vsapsai added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:929 - /// \param[out] NameOut - The return value. - void GetNameForMethod(const ObjCMethodDecl *OMD, -const ObjCContainerDecl *CD, Note that the removed method

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis added a comment. https://reviews.llvm.org/D88497 will fix the leak Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 ___ cfe-commits mailing list

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis added a comment. Oops, I meant to create a new commit rather than amend to this one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 ___ cfe-commits mailing

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis updated this revision to Diff 295000. ellis added a comment. [objc] Fix memory leak in CGObjCMac.cpp CGObjCMac.cpp was leaking a MangleContext everytime it mangled an ObjC method. We now have an instance variable that allocates and deallocates the context. Repository: rG LLVM Github

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

rjmccall added a comment. Done as 98ef7e29b0fe03da77fa6ef5c86bea9e31c178d0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis added a comment. Thanks for accepting @rjmccall. Could you land this? I don't have commit access yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 ___

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis updated this revision to Diff 294503. ellis added a comment. Update call sites Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 Files: clang/include/clang/AST/Mangle.h

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis updated this revision to Diff 294461. ellis added a comment. Rename `mangleObjCMethodName` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 Files: clang/include/clang/AST/Mangle.h

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

rjmccall added inline comments. Comment at: clang/include/clang/AST/Mangle.h:130 + bool includeCategoryNamespace = true); void mangleObjCMethodName(const ObjCMethodDecl *MD, raw_ostream &); Could you switch the polarity

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis updated this revision to Diff 294395. ellis added a comment. Fix variable name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88329/new/ https://reviews.llvm.org/D88329 Files: clang/include/clang/AST/Mangle.h clang/lib/AST/Mangle.cpp

[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

ellis created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ellis requested review of this revision. This reduces code duplication between CGObjCMac.cpp and Mangle.cpp for generating the mangled name of an Objective-C method. This has no intended