This revision was automatically updated to reflect the committed changes.
Closed by commit rG36501b180a4f: Emit predefined macro for wavefront size for
amdgcn (authored by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
yaxunl updated this revision to Diff 295326.
yaxunl added a comment.
simplifies wavefrontsize64 target feature
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88370/new/
https://reviews.llvm.org/D88370
Files:
clang/lib/Basic/Targets/AMDGPU.cpp
clang/lib/Basic/Targets/AMDGPU.h
yaxunl updated this revision to Diff 295312.
yaxunl added a comment.
simpler code for handling multiple wave64 options
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88370/new/
https://reviews.llvm.org/D88370
Files:
clang/lib/Basic/Targets/AMDGPU.cpp
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:394-395
+ // Get the last argument of -mwavefrontsize64 or -mno-wavefrontsize64.
+ for (auto WaveArg : Args.filtered_reverse(options::OPT_mwavefrontsize64,
+
arsenm added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:394-395
+ // Get the last argument of -mwavefrontsize64 or -mno-wavefrontsize64.
+ for (auto WaveArg : Args.filtered_reverse(options::OPT_mwavefrontsize64,
+
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:394-395
+ // Get the last argument of -mwavefrontsize64 or -mno-wavefrontsize64.
+ for (auto WaveArg : Args.filtered_reverse(options::OPT_mwavefrontsize64,
+
arsenm added inline comments.
Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:394-395
+ // Get the last argument of -mwavefrontsize64 or -mno-wavefrontsize64.
+ for (auto WaveArg : Args.filtered_reverse(options::OPT_mwavefrontsize64,
+
yaxunl updated this revision to Diff 295297.
yaxunl edited the summary of this revision.
yaxunl added a comment.
Add test and fix multiple -m[no-]wavefrontsize64 issue.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88370/new/
https://reviews.llvm.org/D88370
Files:
arsenm added inline comments.
Comment at: clang/test/Driver/amdgpu-macros.cl:380-381
+// RUN: -mno-wavefrontsize64 %s 2>&1 | FileCheck --check-prefixes=WAVE64 %s
+// RUN: %clang -E -dM -target amdgcn -mcpu=gfx1010 -mwavefrontsize64 \
+// RUN: -mno-wavefrontsize64 %s 2>&1 |
yaxunl marked an inline comment as done.
yaxunl added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88370/new/
https://reviews.llvm.org/D88370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yaxunl updated this revision to Diff 294790.
yaxunl added a comment.
revised by Matt's comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88370/new/
https://reviews.llvm.org/D88370
Files:
clang/lib/Basic/Targets/AMDGPU.cpp
clang/lib/Basic/Targets/AMDGPU.h
yaxunl updated this revision to Diff 294734.
yaxunl marked an inline comment as done.
yaxunl added a comment.
capitalize macro
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88370/new/
https://reviews.llvm.org/D88370
Files:
clang/lib/Basic/Targets/AMDGPU.cpp
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/lib/Basic/Targets/AMDGPU.h:419
+
+if (llvm::find(Features, "+wavefrontsize64") != Features.end())
+ WavefrontSize = 64;
arsenm wrote:
> Why is this not redundant
arsenm added inline comments.
Comment at: clang/lib/Basic/Targets/AMDGPU.h:419
+
+if (llvm::find(Features, "+wavefrontsize64") != Features.end())
+ WavefrontSize = 64;
Why is this not redundant with the features check?
CHANGES SINCE LAST ACTION
arsenm added inline comments.
Comment at: clang/test/Driver/amdgpu-macros.cl:351
+
+// GFX600-DAG: #define __amdgcn_wavefront_size 64
+// GFX601-DAG: #define __amdgcn_wavefront_size 64
Macros should be all caps
CHANGES SINCE LAST ACTION
yaxunl updated this revision to Diff 294534.
yaxunl added a comment.
fix typo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88370/new/
https://reviews.llvm.org/D88370
Files:
clang/lib/Basic/Targets/AMDGPU.cpp
clang/lib/Basic/Targets/AMDGPU.h
clang/test/Driver/amdgpu-macros.cl
yaxunl created this revision.
yaxunl added reviewers: arsenm, b-sumner.
Herald added subscribers: kerbowa, nhaehnle, jvesely.
yaxunl requested review of this revision.
Herald added a subscriber: wdng.
https://reviews.llvm.org/D88370
Files:
clang/lib/Basic/Targets/AMDGPU.cpp
17 matches
Mail list logo