This revision was automatically updated to reflect the committed changes.
Closed by commit rG2cd75f738ec6: Diagnose invalid target ID for AMDGPU
toolchain for assembler (authored by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ashi1 accepted this revision.
ashi1 added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88377/new/
https://reviews.llvm.org/D88377
___
cfe-commits mailing list
yaxunl updated this revision to Diff 295163.
yaxunl marked an inline comment as done.
yaxunl added a comment.
fix bug
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88377/new/
https://reviews.llvm.org/D88377
Files:
clang/lib/Driver/ToolChains/AMDGPU.cpp
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:243
- // Allow using target ID in --offload-arch.
- StringRef GpuArch = translateTargetID(DriverArgs, CC1Args);
+ StringRef GpuArch =
yaxunl updated this revision to Diff 294728.
yaxunl added a comment.
update patch with full context
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88377/new/
https://reviews.llvm.org/D88377
Files:
clang/lib/Driver/ToolChains/AMDGPU.cpp
clang/lib/Driver/ToolChains/AMDGPU.h
ashi1 added a comment.
Could you please add full context? Mostly looks good to me.
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:243
- // Allow using target ID in --offload-arch.
- StringRef GpuArch = translateTargetID(DriverArgs, CC1Args);
+ StringRef GpuArch =
yaxunl created this revision.
yaxunl added reviewers: tra, ashi1, arsenm.
Herald added subscribers: kerbowa, t-tye, Anastasia, tpr, dstuttard, nhaehnle,
jvesely, kzhuravl.
yaxunl requested review of this revision.
Herald added a subscriber: wdng.
AMDGPU toolchain currently only diagnose invalid
