[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 297008. jhuber6 added a comment. Updating tests after landing D88594 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88430/new/ https://reviews.llvm.org/D88430 Files:

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

This revision was automatically updated to reflect the committed changes. Closed by commit rG90eaedda9b8e: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D88430?vs=295343=295353#toc Repository:

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, that should mean OpenMPKinds lists all OpenMP runtime functions clang generates, which is great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 295343. jhuber6 added a comment. Forgot to add one of the test changes from D88594 as it makes this one fail too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88430/new/

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 295342. jhuber6 added a comment. Moving the Clang error checks into D88594 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88430/new/ https://reviews.llvm.org/D88430 Files:

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

erichkeane resigned from this revision. erichkeane added a comment. I'm not really a good person to review this, OMP isn't nearly my expertise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88430/new/ https://reviews.llvm.org/D88430

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 295032. jhuber6 added a reviewer: erichkeane. jhuber6 added a comment. Adding test cases for incompatible architecture messages. Checking the architecture is done by checking all combinations of architectures. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 294819. jhuber6 added a comment. Removed now unused function for generating convergent runtime functions. Updated Clang to print an error message if the user attempts to specify incompatible architectures due to a difference in pointer sizes. Repository:

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 updated this revision to Diff 294798. jhuber6 added a comment. Herald added a subscriber: aaron.ballman. Reusing OMPBuilder from CGOpenMPRuntime. Altered the failing test case. This case failed when compiling for a 32 bit device on a 64 bit host. This case should be considered an error

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

sstefan1 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.h:38 + /// An OpenMP-IR-Builder instance. + llvm::OpenMPIRBuilder OMPBuilder; + jhuber6 wrote: > sstefan1 wrote: > > There's already an instance of `OpenMPIRBuilder` in

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.h:38 + /// An OpenMP-IR-Builder instance. + llvm::OpenMPIRBuilder OMPBuilder; + sstefan1 wrote: > There's already an instance of `OpenMPIRBuilder` in `CGOpenMPRuntime`. > > Maybe

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

sstefan1 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.h:38 + /// An OpenMP-IR-Builder instance. + llvm::OpenMPIRBuilder OMPBuilder; + There's already an instance of `OpenMPIRBuilder` in `CGOpenMPRuntime`. Maybe just make it

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 added a comment. This currently fails some Clang tests because of an error with how `size_t` is handled by Clang versus OMPKinds.def. The compiler will crash when generating code for a 32 bit device on a 64 bit host because Clang uses the `size_t` from the host while OMPKinds.def uses

[PATCH] D88430: [OpenMP] Replace OpenMP RTL Functions With OMPIRBuilder and OMPKinds.def

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. jhuber6 added projects: OpenMP, LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, guansong, yaxunl. jhuber6 requested review of this revision. Herald added a subscriber: sstefan1. Replace the OpenMP Runtime