Re: [PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

Yes, sorry about that. It has been fixed in 6342b38c5fee74df94d7b0c34e5a93b9b22763df. On Wed, Sep 30, 2020 at 11:12 AM Rainer Orth via Phabricator < revi...@reviews.llvm.org> wrote: > ro added a comment. > > This patch broke builds with `gcc`, e.g. Builder clang-solaris11-amd64 > Build #6724 < >

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

ro added a comment. This patch broke builds with `gcc`, e.g. Builder clang-solaris11-amd64 Build #6724 : [23/122] Building CXX object tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o FAILED:

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ba0779fbb41: [clangd] Extract options struct for ClangdLSPServer. NFC (authored by sammccall). Changed prior to commit:

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:56 + // Features like indexing must be enabled if desired. + static Options optsForTest(); +

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

sammccall updated this revision to Diff 294907. sammccall added a comment. Drop redundant 'opts' from member names of per-feature opts structs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88470/new/ https://reviews.llvm.org/D88470 Files:

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:39 public: - /// If \p CompileCommandsDir has a value, compile_commands.json will be - /// loaded only from \p CompileCommandsDir. Otherwise, clangd will look - /// for

[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. In preparation for making