[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

2020-09-29 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Committed (with substantial changes) as 984744a1314ce165378e7945bc45995302a8cb80 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88497/new/

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

2020-09-29 Thread Jonas Devlieghere via Phabricator via cfe-commits
JDevlieghere added a comment. Thanks for updating the comment in dsymutil! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88497/new/ https://reviews.llvm.org/D88497 ___ cfe-commits mailing list

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

2020-09-29 Thread Ellis Hoag via Phabricator via cfe-commits
ellis updated this revision to Diff 295055. ellis added a subscriber: vsapsai. ellis added a comment. Herald added a reviewer: JDevlieghere. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Fix a comment to reference the correct method. Thanks to @vsapsai for pointing this

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

2020-09-29 Thread Ellis Hoag via Phabricator via cfe-commits
ellis added a comment. Yes please commit for me :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88497/new/ https://reviews.llvm.org/D88497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

2020-09-29 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Oh, oops, I should've caught this in review. I assume you still need a commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88497/new/

[PATCH] D88497: [objc] Fix memory leak in CGObjCMac.cpp

2020-09-29 Thread Ellis Hoag via Phabricator via cfe-commits
ellis created this revision. ellis added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. ellis requested review of this revision. A memory leak was introduced in https://reviews.llvm.org/D88329 CGObjCMac.cpp was leaking a MangleContext everytime it