[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L updated this revision to Diff 299404. Xiangling_L added a comment. Herald added a subscriber: dexonsmith. Edit the definition of `SuitableAlign`; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88659/new/ https://reviews.llvm.org/D88659 Files:

[PATCH] D88659: [FE]Split SuitableAlign into two parts

jyknight added a comment. In D88659#2339357 , @Xiangling_L wrote: > Hi @jyknight , are you okay with us changing the "definition" of > SuitableAlign without sending a note to the mailing list? Yes, I think that it is fine to adjust the comment just in

[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L added a comment. Hi @jyknight , are you okay with us changing the "definition" of SuitableAlign without sending a note to the mailing list? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88659/new/ https://reviews.llvm.org/D88659

[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88659/new/ https://reviews.llvm.org/D88659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D88659: [FE]Split SuitableAlign into two parts

hubert.reinterpretcast added a comment. In D88659#2323631 , @jyknight wrote: > ISTM that comment may be incorrect. At least, the precedent set by GCC > appears to be that BIGGEST_ALIGNMENT and alloca _both_ should follow vector > alignment requirements

[PATCH] D88659: [FE]Split SuitableAlign into two parts

jyknight added a comment. In D88659#2319636 , @hubert.reinterpretcast wrote: > In D88659#2318203 , @jyknight wrote: > >> It seems like on AIX, `__BIGGEST_ALIGNMENT__` should just be set to 16, >> then. I'm not

[PATCH] D88659: [FE]Split SuitableAlign into two parts

hubert.reinterpretcast added a comment. In D88659#2318203 , @jyknight wrote: > It seems like on AIX, `__BIGGEST_ALIGNMENT__` should just be set to 16, then. > I'm not sure why you want it to be 8? /// Return the alignment that is suitable for

[PATCH] D88659: [FE]Split SuitableAlign into two parts

jyknight added a comment. > As you mentioned, without this patch, `SuitableAlign` is used for the > predefined `__BIGGEST_ALIGNMENT__` and alignment for alloca. But on AIX, the > __BIGGEST_ALIGNMENT__ should be 8bytes, alloca and > `__attribute__((aligned))` should align to 16bytes

[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L added a comment. In D88659#2306403 , @jyknight wrote: > Hm, to start with, the current state of this confuses me. > > In GCC, the preprocessor macro `__BIGGEST_ALIGNMENT__` was supposed to expose > the alignment used by

[PATCH] D88659: [FE]Split SuitableAlign into two parts

jyknight added a comment. Hm, to start with, the current state of this confuses me. In GCC, the preprocessor macro `__BIGGEST_ALIGNMENT__` was supposed to expose the alignment used by `__attribute__((aligned))` (no arg specified), as well the alignment used for alloca. However, this is no

[PATCH] D88659: [FE]Split SuitableAlign into two parts

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, zarko, Jason, jyknight, efriedma. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,