This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0741a2c9caca: [Clang][unittests][NFC] Break up test in
Callbacks.cpp (authored by stefanp).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
stefanp updated this revision to Diff 296970.
stefanp added a comment.
Added the missing header file.
Added the license comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D6/new/
https://reviews.llvm.org/D6
Files:
gribozavr2 added inline comments.
Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/CallbacksCommon.h:1
+
+using namespace clang;
Please add a license comment and all necessary includes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
gribozavr2 accepted this revision.
gribozavr2 added a reviewer: gribozavr2.
gribozavr2 added a comment.
Thank you! LGTM assuming you only moved the tests into separate cpp files (I
didn't verify that the text is exactly the same).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
stefanp added a comment.
Related to this please see Nemanja's comment on https://reviews.llvm.org/D82485.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D6/new/
https://reviews.llvm.org/D6
___
stefanp created this revision.
stefanp added a reviewer: nemanjai.
Herald added a subscriber: mgorny.
Herald added a project: clang.
stefanp requested review of this revision.
The Callbacks.cpp test was taking a long time to compile on some build bots
causing timeouts. This patch splits up that
