This revision was automatically updated to reflect the committed changes.
Closed by commit rGafff74e5c26f: [HWAsan][NewPM] Handle hwasan like other
sanitizers (authored by aeubanks).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88936/new/
leonardchan accepted this revision.
leonardchan added a comment.
This revision is now accepted and ready to land.
I see. LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88936/new/
https://reviews.llvm.org/D88936
aeubanks added a comment.
diff for hwasan + -O1:
14a15
> @__hwasan_shadow = external global [0 x i8]
72a74,109
> declare void @__hwasan_loadN(i64, i64)
>
> declare void @__hwasan_load1(i64)
>
> declare void @__hwasan_load2(i64)
>
> declare void @__hwasan_load4(i64)
>
> declare void
leonardchan added a comment.
To what extent does the IR change? My only concern is the right codegen is
still produced.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88936/new/
https://reviews.llvm.org/D88936
aeubanks created this revision.
Herald added subscribers: cfe-commits, dexonsmith.
Herald added a project: clang.
aeubanks requested review of this revision.
Move it as an EP callback (-O[123]) or in addSanitizersAtO0.
This makes it not run in ThinLTO pre-link (like the other sanitizers),
so
