[PATCH] D89177: [cmake] Add support for multiple distributions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56f7e5a822b4: [cmake] Add support for multiple distributions (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 344666. smeenai added a comment. Add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/cmake/caches/MultiDistributionExample.cmake

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai marked 3 inline comments as done. smeenai added inline comments. Comment at: llvm/cmake/modules/LLVMDistributionSupport.cmake:39 +# default (unnamed) distribution. +set_property(GLOBAL PROPERTY LLVM_DISTRIBUTION_FOR_${target} " ") + endforeach()

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 344299. smeenai added a comment. Uppercase variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/cmake/caches/MultiDistributionExample.cmake

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 343949. smeenai added a comment. Helper function to get install arg. TODO: Address other review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files:

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 343946. smeenai added a comment. Herald added subscribers: dcaballe, cota, teijeong. Rebase (comments not addressed yet; uploading a pure rebase for easier version comparison) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added inline comments. Comment at: clang/cmake/modules/AddClang.cmake:121 + set(export_to_clangtargets EXPORT Clang${distribution}Targets) + set_property(GLOBAL PROPERTY CLANG${distribution}_HAS_EXPORTS True) endif() phosek

[PATCH] D89177: [cmake] Add support for multiple distributions

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM with a few nits. Comment at: clang/cmake/modules/AddClang.cmake:121 + set(export_to_clangtargets EXPORT Clang${distribution}Targets) +

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. Ping. Assuming everyone is okay with the direction, any comments on the change itself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. In D89177#2332675 , @beanz wrote: > In D89177#2332627 , @ldionne wrote: > >> That isn't what I meant. It's entirely okay for the runtimes to be driven >> via `AddExternalProject` like the

[PATCH] D89177: [cmake] Add support for multiple distributions

beanz added a comment. In D89177#2332627 , @ldionne wrote: > That isn't what I meant. It's entirely okay for the runtimes to be driven via > `AddExternalProject` like the runtimes build does, since that's akin to > having a separate CMake invocation for

[PATCH] D89177: [cmake] Add support for multiple distributions

ldionne added a comment. In D89177#2332626 , @beanz wrote: > In D89177#2332547 , @ldionne wrote: > >> Are the runtimes expected to support this multi-distribution configuration? >> I don't think we'd want to move

[PATCH] D89177: [cmake] Add support for multiple distributions

beanz added a comment. In D89177#2332547 , @ldionne wrote: > Are the runtimes expected to support this multi-distribution configuration? I > don't think we'd want to move libc++ towards building multiple configurations > at once in a single CMake

[PATCH] D89177: [cmake] Add support for multiple distributions

ldionne added a comment. Are the runtimes expected to support this multi-distribution configuration? I don't think we'd want to move libc++ towards building multiple configurations at once in a single CMake invocation -- it's already too complicated to build just one configuration. While I'm

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a subscriber: ldionne. smeenai added a comment. In D89177#2326875 , @phosek wrote: > In D89177#2326832 , @smeenai wrote: > >> In D89177#2325566 , @phosek

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 298251. smeenai added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/cmake/caches/MultiDistributionExample.cmake

[PATCH] D89177: [cmake] Add support for multiple distributions

phosek added a comment. In D89177#2326832 , @smeenai wrote: > In D89177#2325566 , @phosek wrote: > >> We've already considered introducing a similar mechanism so thank you for >> working on this! There's one issue

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. Reading up on the Ninja multi-config generator a bit, you can define your own build types, so you should be able to create e.g. one build type for LTO and another for PIC. You'd still need some external logic to define that you use the LTO mode for executables and the

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai added a comment. In D89177#2325566 , @phosek wrote: > We've already considered introducing a similar mechanism so thank you for > working on this! There's one issue that I haven't figured out how to resolve > and I'd be interested in your

[PATCH] D89177: [cmake] Add support for multiple distributions

phosek added a comment. Herald added a subscriber: rdzhabarov. We've already considered introducing a similar mechanism so thank you for working on this! There's one issue that I haven't figured out how to resolve and I'd be interested in your thoughts: building executables and libraries in

[PATCH] D89177: [cmake] Add support for multiple distributions

compnerd added a comment. I've not taken a thorough look at the changes, but I am definitely in favour of this change (conceptually). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai created this revision. smeenai added reviewers: beanz, compnerd, phosek, tstellar. Herald added subscribers: llvm-commits, cfe-commits, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle,