[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0f287464d8a: [clangd] Add $/memoryUsage LSP extension (authored by kadircet). Changed prior to commit:

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet updated this revision to Diff 298644. kadircet added a comment. s/memoryTree/memoryUsage/g Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89277/new/ https://reviews.llvm.org/D89277 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:623 {"typeHierarchyProvider", true}, +{"memoryTreeProvider", true}, // clangd

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet updated this revision to Diff 298578. kadircet marked 5 inline comments as done. kadircet added a comment. - Add memoryTreeProvider to initialization params - Move serialization logic to Protocol.h and return MemoryTree directly. - Drop `dump` from method name. Repository: rG LLVM

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

sammccall added a comment. This looks really nice! Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:615 {"workspaceSymbolProvider", true}, {"referencesProvider", true}, {"executeCommandProvider", can you add

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet updated this revision to Diff 298460. kadircet added a comment. - As discussed offline moving with compact version of the output, while preserving names starting with an `_` to be leaves. This is also ready for an implementation-wise review now. Repository: rG LLVM Github Monorepo

Re: [PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

On Wed, Oct 14, 2020 at 6:10 PM Kadir Cetinkaya via Phabricator < revi...@reviews.llvm.org> wrote: > kadircet added a comment. > > In D89277#2329947 , @sammccall > wrote: > > > (sorry out today and haven't looked at code yet) > > no worries it is a

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet added a comment. In D89277#2329947 , @sammccall wrote: > (sorry out today and haven't looked at code yet) no worries it is a prototype, I wouldn't spend time looking at the implementation until we agree on the interaction :D OTHO, checking out

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

sammccall added a comment. (sorry out today and haven't looked at code yet) If it's a custom method, I think it should return the data as a json structure - the client already has to have custom support to invoke it, displaying the result isn't much extra work. And I would really love to add

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet added a comment. In D89277#2326376 , @nridge wrote: > This is neat! Are there plans to add vscode client support to invoke this? Yes, since we control the plugin in vscode we should have a way to invoke it there. (we already have support for

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

nridge added a comment. This is neat! Are there plans to add vscode client support to invoke this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89277/new/ https://reviews.llvm.org/D89277 ___

[PATCH] D89277: [clangd] Add $/dumpMemoryTree LSP extension

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Performs a detailed profiling of clangd