[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d77584fe040: [clangd] Call hierarchy (Protocol layer) (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89296/new/ https://reviews.llvm.org/D89296 _

[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

nridge updated this revision to Diff 305406. nridge added a comment. Forgot to rename a few fields Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89296/new/ https://reviews.llvm.org/D89296 Files: clang-tools-extra/clangd/Protocol.cpp clang-tool

[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

nridge updated this revision to Diff 305397. nridge marked 7 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89296/new/ https://reviews.llvm.org/D89296 Files: clang-tools-ext

[PATCH] D89296: [clangd] Call hierarchy (Protocol layer)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Protocol.cpp:1210 + +llvm::json::Value toJSON(const CallHierarchyItem &I) { + llvm::json::Object Result{ we should also populate tags and detail conditionally. rather than providing empty stri