This revision was automatically updated to reflect the committed changes.
Closed by commit rL258650: Clang changes for value profiling (authored by
betulb).
Changed prior to commit:
http://reviews.llvm.org/D8940?vs=45550=45813#toc
Repository:
rL LLVM
http://reviews.llvm.org/D8940
Files:
betulb added a comment.
Committed in revision 258650.
Repository:
rL LLVM
http://reviews.llvm.org/D8940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
It seems this CL is causing Window build to fail -
http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/3885
Could you take a look?
Repository:
rL LLVM
http://reviews.llvm.org/D8940
...@google.com;
x...@google.com; davi...@google.com
Cc: ovya...@google.com; v...@apple.com; ib...@codeaurora.org;
cfe-commits@lists.llvm.org
Subject: Re: [PATCH] D8940: Clang changes for indirect call target profiling
ovyalov added a subscriber: ovyalov.
ovyalov added a comment.
It seems this CL
davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.
LGTM.
I think we also need a user level option to turn value profiling on/off (in
followups).
http://reviews.llvm.org/D8940
___
cfe-commits
betulb updated this revision to Diff 45550.
betulb added a comment.
In this revision:
- Clang no longer attaches function names as metadata.
- Bug fixed in checking the getNumValueSites return value.
- Addressed review comments.
http://reviews.llvm.org/D8940
Files:
lib/CodeGen/CGCall.cpp
betulb marked 3 inline comments as done.
Comment at: lib/CodeGen/CodeGenPGO.cpp:768
@@ +767,3 @@
+};
+Builder.CreateCall(
+CGM.getIntrinsic(llvm::Intrinsic::instrprof_value_profile), Args);
I removed the if check instead. It was not needed since
davidxl added inline comments.
Comment at: lib/CodeGen/CodeGenPGO.cpp:768
@@ +767,3 @@
+ llvm::IndexedInstrProfReader *PGOReader = CGM.getPGOReader();
+ if (!InstrumentValueSites && !PGOReader)
+return;
&& --> ||
Comment at:
betulb added a comment.
ping?
http://reviews.llvm.org/D8940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added a subscriber: vsk.
vsk added a comment.
Thanks betul! Just a minor nit.
Comment at: lib/CodeGen/CGCall.cpp:3550
@@ +3549,3 @@
+DirectCallee = dyn_cast (Callee);
+ if (!DirectCallee)
+PGO.valueProfile(Builder, llvm::IPVK_IndirectCallTarget,
davidxl added a comment.
Betul, is this patch up to date?
http://reviews.llvm.org/D8940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
betulb added a comment.
No it's not. I need to replace the API's w/ the recent ones for retrieving the
value profile data and add the flag definition for -fprofile-values.
This was off the radar due to other commitments. I'll get back to this
beginning of this week.
-Betul
12 matches
Mail list logo
