ianlevesque updated this revision to Diff 298534.
ianlevesque added a comment.
Apply the fix in XRayInstrumentation, add test cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89441/new/
https://reviews.llvm.org/D89441
Files:
llvm/lib/CodeGen
dberris added a comment.
> Do you think we should fix this by handling the xray-never attribute in
> XRayInstrumentation, or having CodeGenFunction remove the threshold if
> xray-never is set?
Good catch, thanks!
I think we should go with the former (handling the case in XRayInstrumentation)
ianlevesque created this revision.
ianlevesque added reviewers: dberris, MaskRay.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
ianlevesque requested review of this revision.
When using https://reviews.llvm.org/D87953 I discovered that the
fun
