dexonsmith added inline comments.
Comment at: clang/include/clang/Basic/FileManager.h:101
+ /// Type used in the StringMap.
+ using MapEntry = llvm::StringMapEntry>;
+
thakis wrote:
> thakis wrote:
> > It looks like this is too clever for gcc5.3:
> >
thakis added inline comments.
Comment at: clang/include/clang/Basic/FileManager.h:101
+ /// Type used in the StringMap.
+ using MapEntry = llvm::StringMapEntry>;
+
thakis wrote:
> It looks like this is too clever for gcc5.3:
>
thakis added inline comments.
Herald added a subscriber: ormris.
Comment at: clang/include/clang/Basic/FileManager.h:101
+ /// Type used in the StringMap.
+ using MapEntry = llvm::StringMapEntry>;
+
It looks like this is too clever for gcc5.3:
This revision was automatically updated to reflect the committed changes.
dexonsmith marked 2 inline comments as done.
Closed by commit rG917acac960d4: FileManager: Shrink FileEntryRef to the size
of a pointer (authored by dexonsmith).
Herald added a project: clang.
Changed prior to commit:
dexonsmith marked 3 inline comments as done.
dexonsmith added inline comments.
Comment at: clang/lib/Basic/FileManager.cpp:217
FileEntry *FE;
-if (LLVM_LIKELY(FE = Value.dyn_cast()))
- return FileEntryRef(SeenFileInsertResult.first->first(), *FE);
-return
dexonsmith updated this revision to Diff 300811.
dexonsmith added a comment.
Updated to address remaining review comments.
Note that we discussed double-redirection use case offline, and agreed it
doesn't come up in practice (even with multiple RedirectingFileSystem layers)
so we shouldn't
dexonsmith planned changes to this revision.
dexonsmith added inline comments.
Comment at: clang/lib/Basic/FileManager.cpp:219
+ return FileEntryRef(*SeenFileInsertResult.first);
+return FileEntryRef(*Value.V.get());
}
arphaman wrote:
> It looks like
dexonsmith updated this revision to Diff 300791.
dexonsmith added a comment.
Adding a test for multi-level indirection.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89488/new/
https://reviews.llvm.org/D89488
Files:
clang/include/clang/Basic/FileManager.h
arphaman added inline comments.
Comment at: clang/lib/Basic/FileManager.cpp:217
FileEntry *FE;
-if (LLVM_LIKELY(FE = Value.dyn_cast()))
- return FileEntryRef(SeenFileInsertResult.first->first(), *FE);
-return getFileRef(*Value.get(), openFile, CacheFailure);
+
dexonsmith updated this revision to Diff 299246.
dexonsmith edited the summary of this revision.
dexonsmith added a comment.
Improved the naming of the helper types for `FileEntryRef` and the
`SeenFileEntries` map and removed dead code for the old typedef. Found when
working on a follow-up.
dexonsmith updated this revision to Diff 298530.
dexonsmith retitled this revision from "WIP: FileManager: Shrink FileEntryRef
to the size of a pointer" to "FileManager: Shrink FileEntryRef to the size of a
pointer".
dexonsmith added a comment.
Rebase on top of https://reviews.llvm.org/D89521
11 matches
Mail list logo
