This revision was automatically updated to reflect the committed changes.
Closed by commit rG22e6b1863e74: SourceManager: Fix an SLocEntry memory
regression introduced with FileEntryRef (authored by dexonsmith).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
dexonsmith added a comment.
Thanks for the review! @JDevlieghere, let me know if the updated patch looks
good to you too (also the prep commit).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89580/new/
https://reviews.llvm.org/D89580
___
dexonsmith updated this revision to Diff 300377.
dexonsmith added a comment.
Rebased on top of https://reviews.llvm.org/D89580, which implements
@JDevlieghere's suggestion.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89580/new/
https://reviews.llvm.org/D89580
Files:
dexonsmith planned changes to this revision.
dexonsmith added inline comments.
Comment at: clang/include/clang/Basic/SourceManager.h:293
X.ContentAndKind.setInt(FileCharacter);
- X.Filename = Filename;
+ const_cast(Con).Filename = Filename;
return X;
JDevlieghere added inline comments.
Comment at: clang/include/clang/Basic/SourceManager.h:293
X.ContentAndKind.setInt(FileCharacter);
- X.Filename = Filename;
+ const_cast(Con).Filename = Filename;
return X;
Would it possibly make more
dexonsmith created this revision.
dexonsmith added reviewers: arphaman, Bigcheese.
Herald added a subscriber: ributzka.
dexonsmith requested review of this revision.
4dc5573acc0d2e7c59d8bac2543eb25cb4b32984 added `FileEntryRef` in order to
help enable sharing of a `FileManager` between
