This revision was automatically updated to reflect the committed changes.
ZarkoCA marked 2 inline comments as done.
Closed by commit rGc92f29b05e68: [AIX] Add mabi=vec-extabi options to enable
the AIX extended and default vector… (authored by ZarkoCA).
Repository:
rG LLVM Github Monorepo
CHANG
Xiangling_L accepted this revision.
Xiangling_L added a comment.
LGTM. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89684/new/
https://reviews.llvm.org/D89684
___
cfe-commits mailing list
cfe-co
ZarkoCA marked 7 inline comments as done.
ZarkoCA added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4624
+
+ if (Triple.isOSAIX()) {
+if (Args.hasArg(options::OPT_maltivec) &&
Xiangling_L wrote:
> line 4624 to line 4635 can be simplifi
ZarkoCA updated this revision to Diff 307449.
ZarkoCA added a comment.
Simplified option logic as per suggestion.
Removed stray isXCOFF reference.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89684/new/
https://reviews.llvm.org/D89684
Files:
cl
Xiangling_L added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4624
+
+ if (Triple.isOSAIX()) {
+if (Args.hasArg(options::OPT_maltivec) &&
line 4624 to line 4635 can be simplified to :
```
if (Triple.isOSAIX() && Args.hasArg(options:
ZarkoCA marked 7 inline comments as done.
ZarkoCA added inline comments.
Comment at: clang/test/CodeGen/altivec.c:7
+
+// RUN: %clang -S -emit-llvm -maltivec -mabi=vec-extabi -target
powerpc-unknown-aix %s -o - | FileCheck %s
+// RUN: not %clang -S -emit-llvm -mabi=vec-default
ZarkoCA updated this revision to Diff 307405.
ZarkoCA added a comment.
Went back to old option selection logic as updated version did not emit an
error when selecting 'maltivec` but not `mabi=vec-extabi`.
Fixed formatting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
Xiangling_L added inline comments.
Comment at: clang/include/clang/Basic/LangOptions.def:186
LANGOPT(PPCIEEELongDouble, 1, 0, "use IEEE 754 quadruple-precision
for long double")
+LANGOPT(EnableAIXExtendedAltivecABI, 1, 0, "__EXTABI__ predefined
macro")
CO
ZarkoCA updated this revision to Diff 307192.
ZarkoCA marked 3 inline comments as done.
ZarkoCA added a comment.
Addressed some of the comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89684/new/
https://reviews.llvm.org/D89684
Files:
clan
Xiangling_L added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1443
+ if (Arg *A =
+ Args.getLastArg(OPT_mabi_EQ_vec_default, OPT_mabi_EQ_vec_extabi)) {
ZarkoCA wrote:
> Xiangling_L wrote:
> > Should we also check if target f
ZarkoCA updated this revision to Diff 306696.
ZarkoCA marked an inline comment as done.
ZarkoCA added a comment.
Addressed comments and added a test to check whether the driver passes these
options.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89684/new/
https://reviews.llvm.org/D8968
ZarkoCA marked 5 inline comments as done.
ZarkoCA added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1443
+ if (Arg *A =
+ Args.getLastArg(OPT_mabi_EQ_vec_default, OPT_mabi_EQ_vec_extabi)) {
Xiangling_L wrote:
> Should we als
Xiangling_L added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4616
+ if (Args.hasArg(options::OPT_maltivec) &&
+ (Triple.isOSAIX() || Triple.isOSBinFormatXCOFF())) {
+for (const Arg *A : Args) {
ZarkoCA wrote:
> Xiangling_L wrote:
ZarkoCA marked 10 inline comments as done.
ZarkoCA added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4616
+ if (Args.hasArg(options::OPT_maltivec) &&
+ (Triple.isOSAIX() || Triple.isOSBinFormatXCOFF())) {
+for (const Arg *A : Args) {
-
ZarkoCA updated this revision to Diff 306509.
ZarkoCA marked 3 inline comments as done.
ZarkoCA added a comment.
Addressed comments:
Added and fixed test cases and changed option selection logic.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89684/
DiggerLin accepted this revision.
DiggerLin added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89684/new/
https://reviews.llvm.org/D89684
__
Xiangling_L added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4616
+ if (Args.hasArg(options::OPT_maltivec) &&
+ (Triple.isOSAIX() || Triple.isOSBinFormatXCOFF())) {
+for (const Arg *A : Args) {
I am wondering what cases are not c
ZarkoCA marked 8 inline comments as done.
ZarkoCA added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:532
Options.EmitCallSiteInfo = CodeGenOpts.EmitCallSiteInfo;
+ Options.AIXExtendedAltivecABI = CodeGenOpts.AIXExtendedAltivecABI;
Options.ValueTrackingVar
ZarkoCA updated this revision to Diff 305136.
ZarkoCA retitled this revision from "[AIX] Add mvecnvol and mnovecnvol options
to enable the AIX extended and default vector ABIs. " to "[AIX] Add
mabi=vec-extabi options to enable the AIX extended and default vector ABIs. ".
ZarkoCA edited the summar
19 matches
Mail list logo
