[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

2023-06-22 Thread Ryan Thomas Lynch via Phabricator via cfe-commits
emosy added a comment. Is this tool abandoned? Are maintainers still open to adding this tool? I am interested in it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89765/new/ https://reviews.llvm.org/D89765

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

2020-10-20 Thread Ray Zhang via Phabricator via cfe-commits
oneraynyday updated this revision to Diff 299470. oneraynyday added a comment. - Address clang-tidy - Address using C++17 left-fold expression in C++14 - Address minor style issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89765/new/

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

2020-10-20 Thread Ray Zhang via Phabricator via cfe-commits
oneraynyday added a comment. In D89765#2342624 , @awarzynski wrote: > > - Have you considered sending an RFC to cfe-dev regarding this tool? I think > that it would be a great way of attracting peoples attention. More > importantly, should we add

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

2020-10-20 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. Hi @oneraynyday ! This looks very interesting - thanks for uploading! I've only quickly skimmed through. Two high level points: - Have you considered sending an RFC to cfe-dev regarding this tool? I think that it would be a great way of attracting peoples

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

2020-10-20 Thread Ray Zhang via Phabricator via cfe-commits
oneraynyday added a comment. Hi there, Thank you for taking a look! Sorry about the mess with diff's - this is my first time working with Arcanist. I thought `arc diff --update ` in Arcanist meant a push to the branch. Moving forward, should I use `arc diff` to add extra changes onto the code

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

2020-10-20 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Reminder to upload patches with diff to master, not last patch/commit/upload. Wouldn't it be better for this to be a clang-tidy check, as opposed to a standalone tool? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89765: [LibTooling][Clang-cast] A Clang LibTool to convert C-style casts to C++ style casts and more.

2020-10-20 Thread Ray Zhang via Phabricator via cfe-commits
oneraynyday updated this revision to Diff 299274. oneraynyday added a comment. Don't use C++17 features as clang currently uses C++14. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89765/new/ https://reviews.llvm.org/D89765 Files: