This revision was automatically updated to reflect the committed changes.
Closed by commit rG05bef88eb3ec: [AIX] Let alloca return 16 bytes alignment
(authored by Xiangling_L).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89910/new/
hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.
LGTM; thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89910/new/
https://reviews.llvm.org/D89910
Xiangling_L updated this revision to Diff 300043.
Xiangling_L marked an inline comment as done.
Xiangling_L added a comment.
Add one case to the test;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89910/new/
https://reviews.llvm.org/D89910
Files:
clang/lib/Basic/Targets/PPC.h
Xiangling_L marked an inline comment as done.
Xiangling_L added inline comments.
Comment at: clang/test/CodeGen/aix_alloca_align.c:11
+void foo() {
+ char *ptr1 = (char *)alloca(sizeof(char) * 9);
+}
hubert.reinterpretcast wrote:
> I'm not entirely sure, but
hubert.reinterpretcast added inline comments.
Comment at: clang/test/CodeGen/aix_alloca_align.c:11
+void foo() {
+ char *ptr1 = (char *)alloca(sizeof(char) * 9);
+}
I'm not entirely sure, but can we try for size 32 and see if we get 16?
CHANGES SINCE LAST
Xiangling_L updated this revision to Diff 299975.
Xiangling_L marked 3 inline comments as done.
Xiangling_L added a comment.
Fixed the testcase formatting issues;
Fixed the `BIGGEST_ALIGNMENT` value in testcases;
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89910/new/
hubert.reinterpretcast added inline comments.
Comment at: clang/test/CodeGen/aix_alloca_align.c:2
+// RUN: %clang_cc1 -triple=powerpc-ibm-aix-xcoff -S -emit-llvm < %s | \
+// RUN: FileCheck -check-prefix 32BIT %s
+
Minor nit: Use double-hyphen for long option
Xiangling_L created this revision.
Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, ZarkoCA.
Herald added subscribers: cfe-commits, dexonsmith, kbarton, nemanjai.
Herald added a project: clang.
Xiangling_L requested review of this revision.
On AIX, to support vector types, which
