[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

sammccall added a comment. Still LG thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89946/new/ https://reviews.llvm.org/D89946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGefa9aaad703e: [clang] Suppress "follow-up" diagnostics on recovery call expressions. (authored by hokein). Repository: rG LLVM Github Monorepo CH

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12808 + // using RecoveryExpr. + return SemaRef.CreateRecoveryExpr(CallE.get()->getBeginLoc(), +CallE.get()->getEndLoc(), {CallE.get()}); sammccall wro

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein updated this revision to Diff 300601. hokein marked an inline comment as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89946/new/ https://reviews.llvm.org/D89946 Files: clang/lib/Sema/SemaOv

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! LG with comment nit Comment at: clang/lib/Sema/SemaOverload.cpp:12808 + // using RecoveryExpr. + return SemaRef.CreateRecoveryExpr(CallE.get()->getBeginLoc(),

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein updated this revision to Diff 300590. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89946/new/ https://reviews.llvm.org/D89946 Files: clang/lib/Sema/SemaOve

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12814 // end up here. return SemaRef.BuildCallExpr(/*Scope*/ nullptr, NewFn.get(), LParenLoc, MultiExprArg(Args.data(), Args.size()), sammccall wrote:

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12814 // end up here. return SemaRef.BuildCallExpr(/*Scope*/ nullptr, NewFn.get(), LParenLoc, MultiExprArg(Args.data(), Args.size()), hokein wrote:

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12814 // end up here. return SemaRef.BuildCallExpr(/*Scope*/ nullptr, NewFn.get(), LParenLoc, MultiExprArg(Args.data(), Args.size()), sammccall wrote:

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein updated this revision to Diff 300187. hokein marked 4 inline comments as done. hokein added a comment. address comments and add AST tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89946/new/ https://reviews.llvm.org/D89946 Files: cla

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

sammccall added a comment. Cool, this makes sense to me. I hadn't realized this doesn't go through typoexpr, that's a bit unfortunate we can't address this just in one place. This is a change of behavior with recoveryAST off, but this change basically only affects C++ so that's not a widely-use

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein added inline comments. Comment at: clang/test/Modules/submodules-merge-defs.cpp:21 extern class A pre_a2; -int pre_use_a = use_a(pre_a2); // expected-error 2{{'A' must be defined}} expected-error {{'use_a' must be declared}} +int pre_use_a = use_a(pre_a2); // expected-er

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein created this revision. hokein added reviewers: rsmith, sammccall. Herald added a subscriber: kristof.beyls. Herald added a project: clang. hokein requested review of this revision. Because of typo-correction, the AST can be transformed, and the transformed AST is marginally useful for diagn