Conanap closed this revision.
Conanap added a comment.
Pushed; differential revision link accidentally had an extra `https://` so it
did not automatically close.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
___
cfe-commits mailing list
Conanap updated this revision to Diff 317355.
Conanap marked 2 inline comments as done.
Conanap added a comment.
Loads Hi before Lo now; removed implicit cast.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
Files:
nemanjai requested changes to this revision.
nemanjai added a comment.
This revision now requires changes to proceed.
This is still incorrect. The indices for the hi/low words are backwards. You
can easily demonstrate this with a test case such as:
a.c:
vector double test() { return (vector
NeHuang accepted this revision as: NeHuang.
NeHuang added a comment.
LGTM and please wait for Nemanja's approval before committing this patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
___
Conanap updated this revision to Diff 314443.
Conanap added a comment.
Fixed a typo that prevented successful builds
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
Files:
llvm/lib/Target/PowerPC/PPCISelLowering.cpp
Conanap updated this revision to Diff 314439.
Conanap added a comment.
Removed unecessary ternary
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
Files:
llvm/lib/Target/PowerPC/PPCISelLowering.cpp
llvm/lib/Target/PowerPC/PPCInstrPrefix.td
Conanap marked an inline comment as done.
Conanap added a comment.
initialize as a form of undef instead
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
___
cfe-commits mailing list
Conanap updated this revision to Diff 314431.
Conanap marked 4 inline comments as done.
Conanap added a comment.
Addressed some comments for formatting and style
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
Files:
nemanjai requested changes to this revision.
nemanjai added a comment.
This revision now requires changes to proceed.
This is not functionally correct.
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9345
+ return DAG.getBitcast(Op.getValueType(), SplatNode);
+
Conanap added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:2385
+
+ def : Pat <(v2i64 (PPCxxsplti32dx v2i64:$XT, i32:$XI, i32:$IMM32)),
+ (v2i64 (XXSPLTI32DX v2i64:$XT, i32:$XI, i32:$IMM32))>;
amyk wrote:
> It would be good
Conanap updated this revision to Diff 309534.
Conanap marked 4 inline comments as done.
Conanap added a comment.
Removed braces for single lines
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
Files:
Conanap added a comment.
addressed a comment
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9366
+SplatNode = DAG.getNode(
+PPCISD::XXSPLTI32DX, SDLoc(SplatNode), MVT::v2i64, SplatNode,
+DAG.getTargetConstant(isLE ? 1 : 0, SplatNode,
amyk added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9357
+
+ if (Lo) {
+SplatNode =
Braces can be omitted here and on 9364 if it's just a single statement.
Comment at:
Conanap added a comment.
Replied to a comment
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9213
+
+ if (bot) {
+SplatNode = DAG.getNode(
NeHuang wrote:
> I do not quite understand the `if` and `else` logic here, current logic seems
>
Conanap updated this revision to Diff 309039.
Conanap marked 6 inline comments as done.
Conanap added a comment.
Addressed some formatting comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
Files:
NeHuang requested changes to this revision.
NeHuang added inline comments.
This revision now requires changes to proceed.
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9189
HasAnyUndefs, 0, !Subtarget.isLittleEndian());
+ bool LE =
Conanap updated this revision to Diff 305575.
Conanap added a comment.
clang format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
Files:
llvm/lib/Target/PowerPC/PPCISelLowering.cpp
NeHuang added a comment.
Please clang-format the patch to pass pre-merge checks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
___
cfe-commits mailing list
Conanap updated this revision to Diff 302894.
Conanap marked an inline comment as done.
Conanap added a comment.
Updated a test file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
Files:
Conanap marked an inline comment as done.
Conanap added a comment.
The unrelated change no longer shows as diff, thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90173/new/
https://reviews.llvm.org/D90173
Conanap updated this revision to Diff 302886.
Conanap marked 5 inline comments as done.
Conanap added a comment.
Addressed some formatting problems as well as corrected incorrect arguments for
Hi case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
amyk added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9195
+ // If we lose precision, we use XXSPLTI32DX.
+ if (BVNIsConstantSplat && (SplatBitSize == 64) &&
Subtarget.hasPrefixInstrs()) {
+if(convertToNonDenormSingle(APSplatBits) &&
Conanap created this revision.
Conanap added reviewers: PowerPC, nemanjai, saghir.
Conanap added projects: LLVM, clang, PowerPC.
Herald added a subscriber: kbarton.
Conanap requested review of this revision.
Exploits the instruction xxsplti32dx.
It can be used to materialize any 64 bit
24 matches
Mail list logo
