[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

aaron.ballman added a comment. In D90282#2415189 , @smhc wrote: > There's a build failure from this merge, looks like a typo: > > diff --git > a/clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst >

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

smhc added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst:683 +.. option:: EnumConstantIgnoredRegexp + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

smhc added a comment. There's a build failure from this merge, looks like a typo: -.. option:: EnumConstantIgnoredRegexp +.. option:: EnumIgnoredRegexp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90282/new/ https://reviews.llvm.org/D90282

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4df9eecb6c: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress… (authored by smhc, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

smhc added a comment. Yes I thought the same wrt the doco. There is also a hungarian notation config option in the works which does the same thing. I nearly reworked it but figured it would be best done under a separate patch It does have the potential to be less searchable through google for

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

smhc updated this revision to Diff 307177. smhc marked an inline comment as done. smhc added a comment. Removed unnecessary diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90282/new/ https://reviews.llvm.org/D90282 Files:

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

njames93 added a comment. Just one last small nit. // You can ignore this, nothing to do with this patch. All these changes in the documentation tell me we should probably restructure the documentation for this check. Right now we have NxM lines of documentation for each combination of style

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

smhc added a comment. Thanks for the reviews everyone, I have updated the title and summary. Unfortunately I don't have push access to llvm - could someone help to push this please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90282/new/ https://reviews.llvm.org/D90282

[PATCH] D90282: [clang-tidy] Support IgnoredRegexp configuration to selectively suppress identifier naming checks

smhc updated this revision to Diff 307157. smhc marked an inline comment as done. smhc added a comment. Fixed uk/us spelling difference as suggested CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90282/new/ https://reviews.llvm.org/D90282 Files: