[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b104ea4b463: Implement Lambda Conversion Operators for All CCs for MSVC. (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane updated this revision to Diff 302827. erichkeane added a comment. Added test for +lambda as @rsmith requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90634/new/ https://reviews.llvm.org/D90634 Files: clang/lib/Sema/SemaLambda.cpp

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane added inline comments. Comment at: clang/test/CodeGenCXX/lambda-conversion-op-cc.cpp:10 void usage() { auto lambda = [](int i, float f, double d) CC { return i + f + d; }; rsmith wrote: > Does lambda-to-function-pointer decay still work (eg,

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1285 + /// that someone who intentionally places 'thiscall' on the lambda call + /// operator will still get that overload, since we don't have the a way of + /// detecting the attribute by the time we

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane added a comment. In D90634#2371436 , @aaron.ballman wrote: > This LGTM but you should wait a day or so in case @rjmccall has opinions. Thanks, will do! Comment at: clang/lib/Sema/SemaLambda.cpp:1281 + /// Additionally, we

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM but you should wait a day or so in case @rjmccall has opinions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90634/new/ https://reviews.llvm.org/D90634

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane updated this revision to Diff 302595. erichkeane marked 2 inline comments as done. erichkeane added a comment. Made another attempt at fixing the comment. Wordsmithing welcomed/encouraged :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90634/new/

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1282 + /// call-operator calling convention are generated as well. + /// NOTE: We intentionally generate a 'thiscall' (on Win32) despite MSVC not. + /// We do this in order to ensure that someone

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane updated this revision to Diff 302562. erichkeane added a comment. update comment as @aaron.ballman requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90634/new/ https://reviews.llvm.org/D90634 Files: clang/lib/Sema/SemaLambda.cpp

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1281 + /// Additionally, we are ensuring that the default-free/default-member and + /// call-operator calling convention are generated as well. + if (S.getLangOpts().MSVCCompat) {

[PATCH] D90634: Implement Lambda Conversion Operators for All CCs for MSVC.

erichkeane created this revision. erichkeane added reviewers: rjmccall, aaron.ballman. Herald added subscribers: mgrang, kristof.beyls. erichkeane requested review of this revision. As described here: https://devblogs.microsoft.com/oldnewthing/20150220-00/?p=44623 In order to allow Lambdas to be