thakis added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:366
}
-return OptionsSource(*ParsedOptions, ConfigFile.c_str());
+return OptionsSource(*ParsedOptions, ConfigFile.str());
}
This breaks bootstrap builds
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd725f1ce5318: [clang-tidy] Use vfs::FileSystem when getting
config (authored by njames93).
Changed prior to commit:
https://reviews.llvm.org/D90992?vs=303630=303658#toc
Repository:
rG LLVM Github
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a nit with the test.
Comment at: clang-tools-extra/unittests/clang-tidy/OptionsProviderTest.cpp:68
+} // namespace clang
\ No newline at end of
njames93 updated this revision to Diff 303630.
njames93 added a comment.
Small tweak to the tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90992/new/
https://reviews.llvm.org/D90992
Files:
clang-tools-extra/clang-tidy/ClangTidyOptions.cpp
njames93 updated this revision to Diff 303629.
njames93 added a comment.
Herald added a subscriber: mgorny.
Added unittest for loading configs from an InMemoryFileSystem.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90992/new/
njames93 created this revision.
njames93 added reviewers: alexfh, aaron.ballman, gribozavr2.
Herald added subscribers: cfe-commits, xazax.hun.
Herald added a project: clang.
njames93 requested review of this revision.
The config providers that look for configuration files currently take a pointer
