This revision was automatically updated to reflect the committed changes.
Closed by commit rGbee61aa7b638: [clang-format] Add --staged/--cached option to
git-clang-format (authored by ortogonal, committed by MyDeveloperDay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ortogonal added a comment.
@MyDeveloperDay Is everything okay with this? Can you help out with the next
step in the process?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90996/new/
https://reviews.llvm.org/D90996
lodato accepted this revision.
lodato added a comment.
This revision is now accepted and ready to land.
Oops, I'm sorry. I meant to test it but ran out of time and then forgot to
click approve. My apologies.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
MyDeveloperDay added a comment.
@lodato are you blocking this review for a reason?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90996/new/
https://reviews.llvm.org/D90996
___
cfe-commits mailing list
ortogonal added inline comments.
Comment at: clang/tools/clang-format/git-clang-format:140
if not opts.diff:
die('--diff is required when two commits are given')
else:
lodato wrote:
> Does there need to be an equivalent check that --staged
ortogonal updated this revision to Diff 381269.
ortogonal added a comment.
Update description on function `compute_diff`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90996/new/
https://reviews.llvm.org/D90996
Files:
lodato requested changes to this revision.
lodato added a comment.
This revision now requires changes to proceed.
Thanks for pushing this through, @ortogonal! The change LGTM, except the two
minor issues listed.
Name: Mark Lodato
Email: lod...@google.com
Comment at:
MyDeveloperDay added a comment.
No problem, I hope your ok if @lodato gets back to us, I think we should
probably try and credit them a least a little.
Like I said let us wait a bit for people to have a chance to take a look (I'm
not in the US hence why I've seen it already),
I doubt there
ortogonal added a comment.
Thanks for all your help (superfast as well)
Yes I need help commiting.
My name: Erik Larsson
My email: karl.erik.lars...@gmail.com
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90996/new/
MyDeveloperDay added a subscriber: lodato.
MyDeveloperDay added a comment.
@lodato if you are still around (I see no changes since 2017), we may be able
to add you as a "Co-author" I'm not sure of the policy, (again I would need
your name and email address)
Co-authored-by: name
Repository:
MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.
Much, thank you for seeing this over the line,
This LGTM, lets wait a bit in case any of the others have a comment.
I assume you need help committing this? if so we need your
ortogonal added a comment.
Thanks for looking into this!
The feature `--staged` adds the possibility to ONLY run clang format on what is
staged.
Lets say you have main.cpp where you have done two changes. You stage one of
them using:
$ git add -p main.cpp
You now have a state were one of
MyDeveloperDay added a comment.
FYI I doubt you'll get a response from the original clang-format code owners as
they have moved on. But I can take a look
Before giving this the ok, I'd like to understand a little more.
if I make a (bad)formatting change in a file which is not already staged
ortogonal updated this revision to Diff 381150.
ortogonal added a comment.
Just refactor it to latest main. I hope this will re-trigger a new build so I
can investigate if there are still tests that fail.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
alex1701c added a comment.
Any update on this topic? I really like this feature.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90996/new/
https://reviews.llvm.org/D90996
___
cfe-commits mailing list
ortogonal created this revision.
ortogonal added reviewers: klimek, Alexander-Shukaev, djasper.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
ortogonal requested review of this revision.
When running git-clang-format in a pre-commit hook it's very useful to be able
to
16 matches
Mail list logo
