[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:86 + + auto IncomingLevel3 = incomingCalls(IncomingLevel2[0].from, Index.get()); + EXPECT_THAT(IncomingLevel3, nridge

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:86 + + auto IncomingLevel3 = incomingCalls(IncomingLevel2[0].from, Index.get()); + EXPECT_THAT(IncomingLevel3, kadircet

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:86 + + auto IncomingLevel3 = incomingCalls(IncomingLevel2[0].from, Index.get()); + EXPECT_THAT(IncomingLevel3, the order of elements in `IncomingLevel2` is

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge added a comment. It looks like `CallHierarchy.IncomingOneFile` in failing on a few of the buildbots (e.g. clang-ppc64be-linux and clang-s390x-linux ), while passing on most of them.

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e6e6a2db674: [clangd] Call hierarchy (XRefs layer, incoming calls) (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge added a comment. Thank you for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 307223. nridge marked 2 inline comments as done. nridge added a comment. Address final review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files:

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. This looks great! Thanks a lot for bearing with me and doing all of this! Comment at: clang-tools-extra/clangd/XRefs.cpp:1613 +if (auto CHI =

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1649 + // into the same CallHierarchyIncomingCall. + llvm::DenseMap ResultMap; + // We can populate the keys of ResultMap, and the FromRanges fields of

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 306951. nridge marked 14 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files:

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:109 +/// Get call hierarchy information at \p Pos. +llvm::Optional> +prepareCallHierarchy(ParsedAST , Position Pos, const SymbolIndex *Index, nridge wrote: > kadircet wrote: > > nridge

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:109 +/// Get call hierarchy information at \p Pos. +llvm::Optional> +prepareCallHierarchy(ParsedAST , Position Pos, const SymbolIndex *Index, kadircet wrote: > nridge wrote: > > kadircet

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

kadircet added a comment. mostly LG, i haven't looked at the tests yet though. Comment at: clang-tools-extra/clangd/XRefs.cpp:1344 + auto Result = declToHierarchyItem(ND); + if (Result) { +Result->deprecated = ND.isDeprecated(); nit: redundant braces

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 305407. nridge added a comment. Update variable names and remove a commented declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files:

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1317 -static Optional -symbolToTypeHierarchyItem(const Symbol , const SymbolIndex *Index, - PathRef TUPath) { kadircet wrote: > that's a great change to have,

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 305400. nridge marked 12 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files:

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1317 -static Optional -symbolToTypeHierarchyItem(const Symbol , const SymbolIndex *Index, - PathRef TUPath) { that's a great change to have, but maybe leave

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge updated this revision to Diff 304048. nridge added a comment. Update a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91122/new/ https://reviews.llvm.org/D91122 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D91122: [clangd] Call hierarchy (XRefs layer, incoming calls)

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Support for outgoing calls is left for a