This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0a4f99c494d0: [clangd] Call hierarchy (ClangdLSPServer
layer) (authored by nridge).
Changed prior to commit:
https://reviews.llvm.org/D91124?vs=30
nridge updated this revision to Diff 306954.
nridge added a comment.
Update as per API changes in xrefs patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91124/new/
https://reviews.llvm.org/D91124
Files:
clang-tools-extra/clangd/ClangdLSPServe
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91124/new/
https://reviews.llvm.org/D91124
nridge updated this revision to Diff 305409.
nridge added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91124/new/
https://reviews.llvm.org/D91124
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
clang-too
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/test/call-hierarchy.test:39
+---
+{"jsonrpc":"2.0","id":2,"method":"callHierarchy/incomingCalls","params":{"item":{"data":"F0E64FE3F8FEA480","kind":12,"name":"callee","range":{"end":{"character":16,"line":0},"st
nridge added a comment.
Thanks for the reviews!
Comment at: clang-tools-extra/clangd/test/call-hierarchy.test:39
+---
+{"jsonrpc":"2.0","id":2,"method":"callHierarchy/incomingCalls","params":{"item":{"data":"F0E64FE3F8FEA480","kind":12,"name":"callee","range":{"end":{"character
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1228
+Callback>> Reply) {
+ Server->outgoingCalls(Params.Item, std::move(Reply));
+}
as mentioned in the previous review, let's just reply with none/empty here,
with a
nridge created this revision.
nridge added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman.
Herald added a project: clang.
nridge requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Repository:
rG LLVM Github Monorepo
https://rev
