[PATCH] D91278: [Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex

2020-12-07 Thread Sam Elliott via Phabricator via cfe-commits
lenary accepted this revision. lenary added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91278/new/ https://reviews.llvm.org/D91278 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D91278: [Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex

2020-12-07 Thread Luís Marques via Phabricator via cfe-commits
luismarques updated this revision to Diff 309991. luismarques added a comment. Add float Complex case, for regression test completeness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91278/new/ https://reviews.llvm.org/D91278 Files: clang/lib/Co

[PATCH] D91278: [Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex

2020-11-30 Thread Sam Elliott via Phabricator via cfe-commits
lenary added a comment. LGTM - the big hint is that the new test is handled the same as `f_empty_double2` as required by the ABI. Comment at: clang/test/CodeGen/riscv32-ilp32d-abi.cpp:36 + +struct empty_complex { struct {}; double _Complex fc; }; + Please can

[PATCH] D91278: [Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex

2020-11-11 Thread Luís Marques via Phabricator via cfe-commits
luismarques updated this revision to Diff 304554. luismarques added a comment. Fix bad test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91278/new/ https://reviews.llvm.org/D91278 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/ri

[PATCH] D91278: [Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex

2020-11-11 Thread Luís Marques via Phabricator via cfe-commits
luismarques created this revision. luismarques added reviewers: asb, lenary, rjmccall, efriedma. Herald added subscribers: cfe-commits, frasercrmck, NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-