[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

This revision was automatically updated to reflect the committed changes. Closed by commit rGefdd0a29b7eb: [clang][Sparc] Fix __builtin_extract_return_addr etc. (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://revie

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://reviews.llvm.org/D91607 _

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro updated this revision to Diff 404939. ro added a comment. Herald added a subscriber: jrtc27. - Use `CreateGEP` - Add testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://reviews.llvm.org/D91607 Files: clang/lib/CodeGen/Ta

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro added a comment. In D91607#3285825 , @efriedma wrote: > In D91607#3283350 , @ro wrote: > >> In D91607#3280808 , @efriedma wrote: >> >>> Testcase? >> >> I thought the 3 tes

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

efriedma added a comment. In D91607#3283350 , @ro wrote: > In D91607#3280808 , @efriedma wrote: > >> Testcase? > > I thought the 3 testcases adjusted in D91608 > to use `__builtin_

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro added a comment. In D91607#3280808 , @efriedma wrote: > Testcase? I thought the 3 testcases adjusted in D91608 to use `__builtin_extract_return_addr` and fixed by this patch were enough. Otherwise, should I just aug

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

efriedma added a comment. Testcase? Do you need to ptrtoint/inttoptr? I would expect that the address is an `i8*`, so you can just GEP an appropriate number of bytes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://reviews.llvm.

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro added a comment. Ping. This hasn't been reviewed in more than a year and is still required for D91608 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://reviews.llvm.org/D91607

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

ro created this revision. ro added reviewers: efriedma, brad. Herald added subscribers: atanasyan, fedor.sergeev, kristof.beyls, arichardson, sdardis, jyknight. Herald added a project: clang. ro requested review of this revision. While investigating the failures of `symbolize_pc.cpp` and `symbol