[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

2020-11-17 Thread Utkarsh Saxena via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bc085f5b3ed: [clangd] Add OverridenBy Relation to index. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

2020-11-17 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 305976. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed final comments. Ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

2020-11-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/Relation.h:31 +/// { Subject = A, Predicate = BaseOf, Object = B }. +/// - "A::Foo is overriden by B::Foo" is

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

2020-11-17 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 305802. usaxena95 added a comment. Typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 Files: clang-tools-extra/clangd/index/Relation.cpp

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

2020-11-17 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 305787. usaxena95 marked an inline comment as done. usaxena95 added a comment. Add documentation for change in index test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

2020-11-17 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 305783. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. s/OverridenBy/OverriddenBy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 Files:

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

2020-11-17 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/Relation.h:24 BaseOf, + OverridenBy, }; Quuxplusone wrote: > s/Overriden/Overridden/g Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

2020-11-17 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/index-serialization/Inputs/sample.cpp:6 +struct Bar : public Foo { + void Func() override {} +}; could you also add a comment for the reason we have this in the test (i.e. Introduces an