[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

2020-11-17 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 305780. usaxena95 added a comment. Herald added a subscriber: wenlei. Updated sample input for index-serialization test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D9161

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

2020-11-17 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: clang-tools-extra/clangd/index/Relation.cpp:21 + case RelationKind ::OverridenBy: +return OS << "OverridenBy"; + } Also here. And there's a bogus extra space in `RelationKind ::BaseOf`. Comme

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

2020-11-17 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 marked an inline comment as done. usaxena95 added a comment. Bumped the index version. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 ___ cfe-c

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

2020-11-17 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 305776. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 Files: clang-tool

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

2020-11-17 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. Thanks! I think we need to bump the index version number (in `index/Serialization.cpp`) in order to let the index pick up this change. Comment at: clang-tools-extra/clangd/index/Relation.h:29 /// For an example "A is a base class of B" may be represent

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

2020-11-17 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 305727. usaxena95 added a comment. added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 Files: clang-tools-extra/clangd/index/Relation.cpp clang-tool

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

2020-11-17 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This was previously explored in reviews.llvm.org/D69094