Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

jlebar added a comment. > I was not able to figure out how to comandeer a revision, so i just went > ahead and pushed it. Under "leap into action", one of the options is to commandeer the revision. https://reviews.llvm.org/D9168 ___ cfe-commits

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

jlebar added a subscriber: jlebar. jlebar added a comment. FWIW I have run into this in the past and just not managed to muster up the energy to fix it. So, thank you! https://reviews.llvm.org/D9168 ___ cfe-commits mailing list

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy added a comment. @jpienaar Since I don't have commit access, I think somebody else needs to commit this. https://reviews.llvm.org/D9168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy updated this revision to Diff 71951. vchuravy added a comment. Fix spelling in comment https://reviews.llvm.org/D9168 Files: lib/Target/NVPTX/NVPTXISelLowering.cpp lib/Target/NVPTX/NVPTXISelLowering.h test/CodeGen/NVPTX/zero-cs.ll Index: test/CodeGen/NVPTX/zero-cs.ll

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

jpienaar accepted this revision. jpienaar added a reviewer: jpienaar. jpienaar added a comment. This revision is now accepted and ready to land. Looks good to me, do you need help submitting? Comment at: lib/Target/NVPTX/NVPTXISelLowering.cpp:1032 @@ +1031,3 @@ + if (!CS) { +

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy updated this revision to Diff 71946. vchuravy added a comment. addresses review comments. https://reviews.llvm.org/D9168 Files: lib/Target/NVPTX/NVPTXISelLowering.cpp lib/Target/NVPTX/NVPTXISelLowering.h test/CodeGen/NVPTX/zero-cs.ll Index: test/CodeGen/NVPTX/zero-cs.ll

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy added a comment. > You don't own revision D9168: "[NVPTX] Check if callsite is defined when > computing argument allignment". Normally, you should only update > revisions you own. You can "Commandeer" this revision from the web > interface if you want to become the owner. I

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

jpienaar added a comment. Cool. I didn't know the review system allows having the patch updated like this :) It still reports me as the author and you as a subscriber. I don't think that matters. Comment at: lib/Target/NVPTX/NVPTXISelLowering.cpp:1033 @@ +1032,3 @@ +

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy updated this revision to Diff 71936. vchuravy added a comment. Rebases the original changes and adds a test-case https://reviews.llvm.org/D9168 Files: lib/Target/NVPTX/NVPTXISelLowering.cpp lib/Target/NVPTX/NVPTXISelLowering.h test/CodeGen/NVPTX/zero-cs.ll Index:

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy added a comment. This is my first contribution to llvm so please let me know if I did something wrong in the process https://reviews.llvm.org/D9168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

@Valentin: It would be great if you could give it a go. I tried resurrecting it earlier today but noticed getDataLayout() had been removed and then I got tied up with other pending work. On Mon, Sep 19, 2016 at 5:11 PM, Valentin Churavy wrote: > vchuravy added a comment. >

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy added a comment. @jpienaar are you planning to work on this again? Or should I give it a go? https://reviews.llvm.org/D9168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

vchuravy added a comment. I have a potential test-case for this, but the patch doesn't apply cleanly to master so I was unable to test if this solves the problem. F2433038: strip.ll https://reviews.llvm.org/D9168

Re: [PATCH] D9168: [NVPTX] Check if callsite is defined when computing argument allignment

jpienaar added a comment. Oh, sorry, I didn't see your response before I clicked abandoned. It has been a while, so this patch is pretty stale. https://reviews.llvm.org/D9168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org