[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies added a comment. I have also considered these problems, and here is some points of my view. **Latency** Consider llvm-project itself, **textDocument/codeLens** can be done in <500ms generally and <100ms if collect hierarchy is disabled in my notebook. Latency is significant in

[PATCH] D91930: [clangd] Implement textDocument/codeLens

kadircet added a comment. Thanks for the explanations. I've also had some discussions with @sammccall about this and would like to summarize them. There are two important things to keep in mind: - Collection is performed for the whole document. - Resolve requests cannot fail. (there's no

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies added a comment. In D91930#2411338 , @kadircet wrote: > Thanks a lot for working on improving clangd! > > Can you also give a high-level overview of what kind of functionality you are > providing here? Looks like there's a lot going on

[PATCH] D91930: [clangd] Implement textDocument/codeLens

kadircet added a comment. Thanks a lot for working on improving clangd! Can you also give a high-level overview of what kind of functionality you are providing here? Looks like there's a lot going on here, and it would be nice to know what you are attempting to do, rather than inferring that

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies updated this revision to Diff 306916. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91930/new/ https://reviews.llvm.org/D91930 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clangd/ClangdLSPServer.h clang-tools-extra/clangd/ClangdServer.cpp

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies updated this revision to Diff 306912. lightmelodies edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91930/new/ https://reviews.llvm.org/D91930 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D91930: [clangd] Implement textDocument/codeLens

njames93 added a comment. Please upload the diff with full context and fix the failing unit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91930/new/ https://reviews.llvm.org/D91930 ___ cfe-commits

[PATCH] D91930: [clangd] Implement textDocument/codeLens

lightmelodies created this revision. lightmelodies added reviewers: kadircet, sammccall. lightmelodies added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, arphaman, javed.absar. Herald added a project: clang. lightmelodies requested review of this revision. Herald