[PATCH] D92000: [clangd] Collect main file refs by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6cb47b640ff: [clangd] Collect main file refs by default (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92000: [clangd] Collect main file refs by default

nridge updated this revision to Diff 307730. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92000/new/ https://reviews.llvm.org/D92000 Files: clang-tools-extra/clangd/ClangdServer.h

[PATCH] D92000: [clangd] Collect main file refs by default

kadircet added a comment. nope, as it doesn't change the serialization format. but any existing shards won't have refs from the main file, they'll accumulate over time as sources gets modified. (i don't think it is worth bumping the version to invalidate existing shards, if a user cares enough

[PATCH] D92000: [clangd] Collect main file refs by default

nridge added a comment. One thing that just occurred to me: does this need an index version bump? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92000/new/ https://reviews.llvm.org/D92000 ___ cfe-commits

[PATCH] D92000: [clangd] Collect main file refs by default

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:492 desc("Store references to main-file-only symbols in the index"), -init(false), +

[PATCH] D92000: [clangd] Collect main file refs by default

nridge added a comment. Note, the call hierarchy feature is pretty significantly impaired without this. See the example of `Selection::createEach()` discussed in this comment . Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92000: [clangd] Collect main file refs by default

kadircet added a comment. NVM, found the summary https://github.com/clangd/clangd/issues/162#issuecomment-653981038 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92000/new/ https://reviews.llvm.org/D92000

[PATCH] D92000: [clangd] Collect main file refs by default

kadircet added a comment. i remember discussing this in the past, and having "negative" feelings about it. I couldn't find the discussion on the issues page tho, could you toss me the link if you can find it? (it might've been an offline discussion as well, sorry if that's the case for not

[PATCH] D92000: [clangd] Collect main file refs by default

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is needed for call hierarchy to be able to