[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf added a comment. In D92815#2753684 , @nemanjai wrote: > Looks like this is causing failures at > https://lab.llvm.org/buildbot/#/builders/76/builds/2422 > Please revert. Yes. Already reverted in

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

nemanjai added a comment. Looks like this is causing failures at https://lab.llvm.org/buildbot/#/builders/76/builds/2422 Please revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92815/new/ https://reviews.llvm.org/D92815

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfebbe4b5a0ab: [PowerPC] [Clang] Enable float128 feature on VSX targets (authored by qiucf). Changed prior to commit:

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Basic/Targets/PPC.cpp:359 llvm::find(FeaturesVec, "+float128") != FeaturesVec.end()) { -// We have __float128 on PPC but not power

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf added a comment. Ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92815/new/ https://reviews.llvm.org/D92815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

steven.zhang accepted this revision. steven.zhang added a comment. LGTM now. But please hold on for at least one week to see if @nemanjai has concern. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92815/new/ https://reviews.llvm.org/D92815

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf updated this revision to Diff 327388. qiucf added a comment. Fix redundant code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92815/new/ https://reviews.llvm.org/D92815 Files: clang/lib/Basic/Targets/PPC.cpp

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf updated this revision to Diff 327378. qiucf retitled this revision from "[PowerPC] [Clang] Enable float128 feature on Altivec targets" to "[PowerPC] [Clang] Enable float128 feature on VSX targets". qiucf edited the summary of this revision. qiucf set the repository for this revision to rG